fix: Sort date pair on range close in ThemedDateTimeRangePicker#137
Merged
Conversation
When the range was picked in reverse order (later day first, earlier day second), startDate/endDate were kept in selection order and only sorted at save time. Times entered in the Time tab were glued to the wrong endpoint, so the saved [start, end] list had each time pointing at the opposite date. Sort the date pair the moment the second tap closes the range, so the Time tab always shows Start = earlier day, End = later day, and each time stays aligned with its intended date. chore: Bump version to 7.5.31 in pubspec.yaml and .claude/plugin.json docs: Add 7.5.31 entry to CHANGELOG.md
📋 Changelog SummaryThis PR includes the following changes: 🐛 Bug Fixes
📚 Documentation
📊 Diff Stats
🤖 Auto-generated by changelog workflow |
📊 Test Coverage Report🎯 Dart/Flutter
🤖 Generated by coverage workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the range was picked in reverse order (later day first, earlier day second), startDate/endDate were kept in selection order and only sorted at save time. Times entered in the Time tab were glued to the wrong endpoint, so the saved [start, end] list had each time pointing at the opposite date. Sort the date pair the moment the second tap closes the range, so the Time tab always shows Start = earlier day, End = later day, and each time stays aligned with its intended date.
chore: Bump version to 7.5.31 in pubspec.yaml and .claude/plugin.json
docs: Add 7.5.31 entry to CHANGELOG.md